Skip to content

Implement ICDF for Laplace and Pareto distributions #6707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2023

Conversation

james-2001
Copy link
Contributor

@james-2001 james-2001 commented May 6, 2023

What is this PR about?
Adds ICDF functions to Laplace and Pareto distributions.

References:

Issue #6612

Checklist

Major / Breaking Changes

New features

Pareto.icdf and Laplace.icdf functions

Bugfixes

Documentation

Maintenance


📚 Documentation preview 📚: https://pymc--6707.org.readthedocs.build/en/6707/

james-2001 added 2 commits May 6, 2023 13:07
Adds ICDF (quantile) function for the laplace distribution. Source https://en.wikipedia.org/wiki/Laplace_distribution

Issue pymc-devs#6612
Adds ICDF (quantile) function for the Pareto distribution. Source https://en.wikipedia.org/wiki/Pareto_distribution

Issue pymc-devs#6612
@welcome
Copy link

welcome bot commented May 6, 2023

Thank You Banner
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #6707 (9abe6fb) into main (371472d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6707   +/-   ##
=======================================
  Coverage   92.00%   92.01%           
=======================================
  Files          95       95           
  Lines       16125    16139   +14     
=======================================
+ Hits        14836    14850   +14     
  Misses       1289     1289           
Impacted Files Coverage Δ
pymc/distributions/continuous.py 97.74% <100.00%> (+0.03%) ⬆️

Copy link
Contributor

@michaelraczycki michaelraczycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@ricardoV94 ricardoV94 changed the title Feature/icdf laplace pareto Implement ICDF for Laplace and Pareto distributions May 11, 2023
@ricardoV94 ricardoV94 merged commit 9b72c2e into pymc-devs:main May 11, 2023
@welcome
Copy link

welcome bot commented May 11, 2023

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

@ricardoV94
Copy link
Member

Thanks @james-2001!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants