Skip to content

NotImplementedError for icdf of non-injective MeasurableTransforms #6793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 23, 2023

We were already doing it for logcdf but not icdf. Also added direct tests.


📚 Documentation preview 📚: https://pymc--6793.org.readthedocs.build/en/6793/

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #6793 (c2fbf78) into main (14e673f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6793      +/-   ##
==========================================
+ Coverage   91.89%   91.91%   +0.01%     
==========================================
  Files          95       95              
  Lines       16185    16187       +2     
==========================================
+ Hits        14874    14878       +4     
+ Misses       1311     1309       -2     
Impacted Files Coverage Δ
pymc/logprob/transforms.py 94.68% <100.00%> (+0.40%) ⬆️

Copy link
Member

@larryshamalama larryshamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some quick questions :)

Preemptively approving this because I can take a while to respond

@ricardoV94 ricardoV94 force-pushed the fail_icdf_elemwise branch from c2fbf78 to 2340e9a Compare June 29, 2023 12:33
@ricardoV94 ricardoV94 merged commit 562fe16 into pymc-devs:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants