Logprob derivation for Min of continuous IID variables #6846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhruvanshu-Joshi
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6846 +/- ##
===========================================
- Coverage 92.03% 49.90% -42.13%
===========================================
Files 96 100 +4
Lines 16369 16848 +479
===========================================
- Hits 15065 8408 -6657
- Misses 1304 8440 +7136
|
Dhruvanshu-Joshi
force-pushed
the
dev_order_min
branch
from
9a120cd to
972ea8a
Compare
ricardoV94
requested changes
Aug 14, 2023
Dhruvanshu-Joshi
force-pushed
the
dev_order_min
branch
from
972ea8a to
086f7fe
Compare
|
@ricardoV94 @larryshamalama Is this PR good to be merged or are we left with something here? |
ricardoV94
reviewed
Sep 4, 2023
ricardoV94
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR aims to provide a solution for implementing the Max operation from order statistics to solve the issue #6350 and issue 6773. This is an extension of #6769. More tests related to MIN operation are to be added.
Checklist
Major / Breaking Changes
New features
pt.minBugfixes
Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--6846.org.readthedocs.build/en/6846/