Skip to content

Implementation of Maxwell Distribution #6907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tvwenger
Copy link
Contributor

@tvwenger tvwenger commented Sep 12, 2023

What is this PR about?
This PR implements the Maxwell distribution following this discussion and this related PR, which implements the Maxwell RV in pytensor. Maxwell distribution appears often in physical systems and having access to it in pymc and pytensor would be generally useful.

I have attempted to follow the style of other similarly-implemented distributions, and I have included the relevant docstrings and tests.

I attempted to run tests/distributions/test_continuous.py before submitting this PR, but I received an error that seems to be irrelevant to these changes.

Checklist

Major / Breaking Changes

  • None

New features

  • Implementation of the Maxwell distribution

Bugfixes

  • None

Documentation

  • Included docstrings as necessary

Maintenance

  • N/A

📚 Documentation preview 📚: https://pymc--6907.org.readthedocs.build/en/6907/

@welcome
Copy link

welcome bot commented Sep 12, 2023

Thank You Banner
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

@tvwenger
Copy link
Contributor Author

Since this implementation depends on the pytensor PR, I don't really know the proper protocol/testing relationship. Any help would be appreciated!

@tvwenger
Copy link
Contributor Author

I was also confused about how to implement test_maxwell_moments, so any help there would be appreciated as well!

@ricardoV94
Copy link
Member

ricardoV94 commented Sep 13, 2023

@tvwenger please open this PR on pymc-experimental.

Let me know if the suggestion to use a CustomDist in the original discussion sounds correct.

@tvwenger
Copy link
Contributor Author

Related PR on pymc-experimental: pymc-devs/pymc-extras#239

@tvwenger tvwenger closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants