Implementation of Maxwell Distribution #6907
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR implements the Maxwell distribution following this discussion and this related PR, which implements the Maxwell RV in
pytensor
. Maxwell distribution appears often in physical systems and having access to it inpymc
andpytensor
would be generally useful.I have attempted to follow the style of other similarly-implemented distributions, and I have included the relevant docstrings and tests.
I attempted to run
tests/distributions/test_continuous.py
before submitting this PR, but I received an error that seems to be irrelevant to these changes.Checklist
Major / Breaking Changes
New features
Maxwell
distributionBugfixes
Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--6907.org.readthedocs.build/en/6907/