Foward compile_kwargs to ADVI when init = "advi+..."#7640
Merged
ricardoV94 merged 5 commits intopymc-devs:mainfrom Jan 9, 2025
Merged
Foward compile_kwargs to ADVI when init = "advi+..."#7640ricardoV94 merged 5 commits intopymc-devs:mainfrom
compile_kwargs to ADVI when init = "advi+..."#7640ricardoV94 merged 5 commits intopymc-devs:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7640 +/- ##
==========================================
- Coverage 92.85% 92.17% -0.68%
==========================================
Files 106 106
Lines 17771 17765 -6
==========================================
- Hits 16501 16375 -126
- Misses 1270 1390 +120
🚀 New features to boost your workflow:
|
ricardoV94
approved these changes
Jan 9, 2025
vandalt
pushed a commit
to vandalt/pymc
that referenced
this pull request
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See title. Now that we are allowed to pass
compile_kwargsto pm.sample, it would be nice if these kwargs were also passed to any subroutines that are called before/after sampling. An obvious example is the call topm.fitwhen the user setsinit = "advi+something". This PR forwards thecompile_kwargsto ADVI.It also renames
fn_kwargstocompile_kwargsin the variational sub-module. This harmonizes the naming convention across the library. A depreciation warning is added whenfn_kwargsis used for backwards compatibility.Related Issue
compile_kwargsin ADVI wheninit = 'advi+...'#7638Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7640.org.readthedocs.build/en/7640/