-
Notifications
You must be signed in to change notification settings - Fork 130
🔄 From Aesara: 1337: Add basic overloads for Numba sparse types #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure where that's from, can't reproduce locally. |
6ea957c
to
c8a651c
Compare
c8a651c
to
c39cd9e
Compare
The issue was that PR relied on changes from #80 which wasn't merged. I tweaked the code to not depend on those changes. It's a difference between dispatching or continuing to use the pre-existing if-else function. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 80.44% 80.42% -0.02%
==========================================
Files 170 170
Lines 45328 45376 +48
Branches 11069 11082 +13
==========================================
+ Hits 36463 36495 +32
- Misses 6642 6654 +12
- Partials 2223 2227 +4
|
Downstream aesara-devs/aesara#1337