Skip to content

🔄 From Aesara: 1337: Add basic overloads for Numba sparse types #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 22, 2023

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented Dec 10, 2022

@ricardoV94 ricardoV94 added aesara downstream PRs that were downstreamed from Aesara and removed aesara downstream PRs that were downstreamed from Aesara labels Dec 13, 2022
@twiecki
Copy link
Member Author

twiecki commented Dec 15, 2022

pytensor/link/numba/dispatch/sparse.py:216: error: "Callable[[Type[Any], str, bool, bool], Any]" has no attribute "register"  [attr-defined]
Found 1 error in 1 file (checked 396 source files)

Not sure where that's from, can't reproduce locally.

@ricardoV94 ricardoV94 changed the title Downstream 1337 🔄 From Aesara: 1337: Add basic overloads for Numba sparse types Mar 22, 2023
@ricardoV94
Copy link
Member

ricardoV94 commented Mar 22, 2023

The issue was that PR relied on changes from #80 which wasn't merged. I tweaked the code to not depend on those changes. It's a difference between dispatching or continuing to use the pre-existing if-else function.

@ricardoV94 ricardoV94 merged commit 220442a into main Mar 22, 2023
@twiecki twiecki deleted the downstream_1337 branch March 22, 2023 12:36
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 68.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (bfd7257) to head (c39cd9e).
Report is 636 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/link/numba/dispatch/basic.py 20.00% 7 Missing and 1 partial ⚠️
pytensor/link/numba/dispatch/sparse.py 79.48% 5 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   80.44%   80.42%   -0.02%     
==========================================
  Files         170      170              
  Lines       45328    45376      +48     
  Branches    11069    11082      +13     
==========================================
+ Hits        36463    36495      +32     
- Misses       6642     6654      +12     
- Partials     2223     2227       +4     
Files with missing lines Coverage Δ
pytensor/link/numba/linker.py 100.00% <100.00%> (ø)
pytensor/link/numba/dispatch/basic.py 87.89% <20.00%> (-1.45%) ⬇️
pytensor/link/numba/dispatch/sparse.py 93.49% <79.48%> (-6.51%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aesara downstream PRs that were downstreamed from Aesara numba
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants