Avoid PyTensor function overhead in OpFromGraph #1375
Draft
+144
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
ofg_c_impl
branch
2 times, most recently
from
95b0cc4 to
bcbe5cf
Compare
ricardoV94
force-pushed
the
ofg_c_impl
branch
2 times, most recently
from
eb7a528 to
12d2e76
Compare
Also provide pure C-implementation when all Ops allow it. LazyLinker does not complain about thunks that return outputs, since itself can be a thunk. Adding a Python wrapper that hides the outputs incurs considerable overhead, and modifying the LazyLinker to optionally not return outputs seems unnecessarily complex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also provide pure C-implementation when all Ops allow it.
This should make us less hesitant to use OpFromGraph in those cases where it makes sense to (complex graph that we want to reason about as if it was a single Op)
📚 Documentation preview 📚: https://pytensor--1375.org.readthedocs.build/en/1375/