Let scalar * tensor fall back to the tensor's reflected operator - #2435
Open
anishmehta24 wants to merge 1 commit into
Open
anishmehta24 wants to merge 1 commit into
anishmehta24 wants to merge 1 commit into
Conversation
…rand is not a scalar
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scalar * tensor(and+,-,/,**, comparisons, bitwise ops) raisedTypeError: Cannot convert b to a scalar type, because the scalar operator methods called the op directly. Python only tries the right operand's reflected method (TensorVariable.__rmul__) when the left one returnsNotImplemented.The binary operator methods on
_scalar_py_operatorsnow go through a small helper that returnsNotImplementedwhen either operand can't be converted withas_scalar, the same idea as the try/except inTensorVariable.__add__. Errors raised by the op itself still propagate, sotest_mod_complex_failkeeps gettingComplexError.Added
test_scalar_tensor_binary_op, parametrized over the operators, next totest_rtruediv; it fails on main.tests/scalarandtests/tensor/test_elemwise.pypass.Related Issue
Checklist
Type of change