Skip to content

Fix miscelaneous bugs #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 4, 2023
Merged

Fix miscelaneous bugs #368

merged 4 commits into from
Jul 4, 2023

Conversation

ricardoV94
Copy link
Member

Spinoff from #361

@ricardoV94 ricardoV94 added the bug Something isn't working label Jul 3, 2023
@ricardoV94 ricardoV94 force-pushed the misc_fixes branch 2 times, most recently from 0d3126a to fdd0eed Compare July 3, 2023 19:52
@ricardoV94
Copy link
Member Author

Argh float32 tests... I swear one day!!!

@codecov-commenter
Copy link

Codecov Report

Merging #368 (250fb20) into main (36161e8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   80.40%   80.40%           
=======================================
  Files         156      156           
  Lines       45404    45401    -3     
  Branches    11106    11106           
=======================================
- Hits        36507    36505    -2     
+ Misses       6690     6689    -1     
  Partials     2207     2207           
Impacted Files Coverage Δ
pytensor/graph/rewriting/utils.py 95.29% <ø> (-0.06%) ⬇️
pytensor/graph/basic.py 89.21% <100.00%> (ø)
pytensor/tensor/elemwise.py 88.05% <100.00%> (+0.03%) ⬆️
pytensor/tensor/rewriting/math.py 86.05% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoV94 ricardoV94 merged commit 5c87d74 into pymc-devs:main Jul 4, 2023
@ricardoV94 ricardoV94 deleted the misc_fixes branch July 4, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants