Cleanup fusion rewrite database #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same behavior can be obtained with `optimizer_excluding` The `local_careduce_rewrite` is now included in this database. Otherwise it would usually not be applied because it ran before the fusion rewrites
ricardoV94
force-pushed
the
misc_rewrites2
branch
from
184ac17 to
c1d0401
Compare
ricardoV94
changed the title
michaelosthege
approved these changes
Jul 4, 2023
Comment on lines
+1186
to
+1192
| pytest.param( | ||
| at_all, | ||
| np.all, | ||
| marks=pytest.mark.xfail( | ||
| reason="Rewrite logic does not support all CAReduce" | ||
| ), | ||
| ), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rewrite for Sum(MakeVector) #346 about tricky aspects of the CAReduce Ops. This rewrite was accidentally rarely used because it was registered outside the fusion database, and ran before the fusion rewrites. This explains why the failures where hidden for so long. It is now included in the same database, which is also related to the next point:
Spinoff from #361