Some numba backend fixes #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aseyboldt
commented
Nov 28, 2022
aseyboldt
commented
- implementations for numba special functions
- numba impl fix for cumop
- Fix for numba svd
- Preserve names in graph replacements
- Remove broken AdvancdIndexing numba op
- Deal with negative axis args
- numba impl for checkandraise
aseyboldt
changed the title
|
@aseyboldt Are you porting over a PR from aesara? If so, you can use the |
|
Yes, I just wanted to make sure we don't duplicate that work |
ricardoV94
reviewed
Nov 29, 2022
ricardoV94
reviewed
Nov 29, 2022
Comment on lines
167
to
176
| def normalize_axis(axis, ndim): | ||
| if axis is None: | ||
| return axis | ||
|
|
||
| if axis < 0: | ||
| axis = ndim + axis | ||
|
|
||
| if axis < 0 or axis >= ndim: | ||
| raise np.AxisError(ndim=ndim, axis=axis) | ||
| return axis |
There was a problem hiding this comment.
You can just use
There was a problem hiding this comment.
Dod you decide not to use these?
ricardoV94
reviewed
Nov 29, 2022
ferrine
reviewed
Nov 29, 2022
ricardoV94
approved these changes
Dec 1, 2022
ferrine
reviewed
Dec 2, 2022
|
|
||
| @dataclass | ||
| class Signature: | ||
| res_dtype: DTypeLike |
There was a problem hiding this comment.
is it a single output signature?
There was a problem hiding this comment.
Yes, this currently only supports scalar return values. This is all we need for the scipy.special functions, but if we need more later (maybe for some linalg stuff?) we might have to expand it a bit.
ricardoV94
approved these changes
Dec 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.