-
Notifications
You must be signed in to change notification settings - Fork 129
Add aliases for arithmetic inequality function equivalents in NumPy #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are others but they're scattered around the module: perhaps they should all be put together? bitwise_and = and_ # numpy name for it bitwise_or = or_ # numpy name for it bitwise_xor = xor # numpy name for it bitwise_not = invert # numpy alias for it # alias to sqr, included to maintain similarity with numpy interface
square = sqr
|
…tyle as existing bitwise ones.
I think it would be great to gather everything into one place |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
=======================================
Coverage 80.90% 80.90%
=======================================
Files 162 162
Lines 46416 46422 +6
Branches 11354 11354
=======================================
+ Hits 37554 37560 +6
Misses 6639 6639
Partials 2223 2223
|
…e end of the file
Need to fix conflicts with changes in main, otherwise ready to merge |
On my 3rd try at interactive rebasing I gave up and did it in the web editor! 😮💨 It kept saying there were going to be 26 commits, I briefly saw the option to squash but it didn't show up on 2nd try, think that was the right way. Oh well, should be good now, looks like the web editor didn't mess up the code style check |
Thanks @lmmx and sorry for the for pain! |
Motivation for these changes
Updated the logical function mappings in PyTensor to align with NumPy's logical functions. This enhances compatibility and eases the transition for users familiar with NumPy, making PyTensor more intuitive and accessible.
Fulfils:
Implementation details
I reviewed the correspondence and made a table in the issue tracker, then made aliases for those that were not a direct name match. I also added them to the
__all__
alongside the names they alias.Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance