Skip to content

Bump actions/upload-artifact from 3 to 4 #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps actions/upload-artifact from 3 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.1.3

What's Changed

Full Changelog: actions/upload-artifact@v3...v3.1.3

v3.1.2

  • Update all @actions/* NPM packages to their latest versions- #374
  • Update all dev dependencies to their most recent versions - #375

v3.1.1

  • Update actions/core package to latest version to remove set-output deprecation warning #351

v3.1.0

What's Changed

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 18, 2023
@maresb
Copy link
Contributor

maresb commented Dec 18, 2023

I haven't looked at the error message here yet, but I think I read that upload-artifact and download-artifact are incompatible across different major versions. The download-artifact PR got merged, so this might be problematic.

@twiecki
Copy link
Member

twiecki commented Dec 18, 2023

Or maybe they both need to be merged as this was still run pre-bump.

@maresb maresb closed this Dec 18, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 18, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@maresb maresb reopened this Dec 18, 2023
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from ba8aa24 to ab64458 Compare December 18, 2023 18:12
@maresb
Copy link
Contributor

maresb commented Dec 18, 2023

Conflict: an artifact with this name already exists on the workflow run

Ah, we need to ensure that the artifact names are all unique.

@maresb
Copy link
Contributor

maresb commented Jul 11, 2024

@dependabot rebase

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from ab64458 to c368145 Compare July 11, 2024 18:42
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.40%. Comparing base (4c71816) to head (872605a).
Report is 110 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   81.37%   81.40%   +0.02%     
==========================================
  Files         170      175       +5     
  Lines       46800    46934     +134     
  Branches    11418    11427       +9     
==========================================
+ Hits        38083    38205     +122     
- Misses       6535     6547      +12     
  Partials     2182     2182              

see 42 files with indirect coverage changes

@maresb maresb requested a review from ricardoV94 July 18, 2024 12:43
@maresb
Copy link
Contributor

maresb commented Jul 18, 2024

Ooh, excellent, all green!!! 🚀

If you approve, then please squash-merge.

@twiecki twiecki merged commit ad27dc7 into main Jul 18, 2024
59 checks passed
@twiecki
Copy link
Member

twiecki commented Jul 18, 2024

Tricky one!

@dependabot dependabot bot deleted the dependabot/github_actions/actions/upload-artifact-4 branch July 18, 2024 16:15
Ch0ronomato pushed a commit to Ch0ronomato/pytensor that referenced this pull request Aug 15, 2024
* Bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Migrate pypi to GHA artifacts v4

* Bump download-artifact to v4

* Eliminate undefined matrix.python-version variable

* Upload/download each platform separately

* Use pattern arg to download-artifact

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Mares <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no releasenotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants