-
Notifications
You must be signed in to change notification settings - Fork 129
Bump actions/upload-artifact from 3 to 4 #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump actions/upload-artifact from 3 to 4 #560
Conversation
I haven't looked at the error message here yet, but I think I read that upload-artifact and download-artifact are incompatible across different major versions. The download-artifact PR got merged, so this might be problematic. |
Or maybe they both need to be merged as this was still run pre-bump. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
ba8aa24
to
ab64458
Compare
Ah, we need to ensure that the artifact names are all unique. |
@dependabot rebase |
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
ab64458
to
c368145
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
+ Coverage 81.37% 81.40% +0.02%
==========================================
Files 170 175 +5
Lines 46800 46934 +134
Branches 11418 11427 +9
==========================================
+ Hits 38083 38205 +122
- Misses 6535 6547 +12
Partials 2182 2182 |
Ooh, excellent, all green!!! 🚀 If you approve, then please squash-merge. |
Tricky one! |
* Bump actions/upload-artifact from 3 to 4 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Migrate pypi to GHA artifacts v4 * Bump download-artifact to v4 * Eliminate undefined matrix.python-version variable * Upload/download each platform separately * Use pattern arg to download-artifact --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Mares <[email protected]>
Bumps actions/upload-artifact from 3 to 4.
Release notes
Sourced from actions/upload-artifact's releases.
Commits
c7d193f
Merge pull request #466 from actions/v4-beta13131bb
licensed cache4a6c273
Merge branch 'main' into v4-betaf391bb9
Merge pull request #465 from actions/robherley/v4-documentation9653d03
Apply suggestions from code review875b630
add limitations sectionecb2146
add compression example5e7604f
trim some repeated infod6437d0
naming1b56155
s/v4-beta/v4/gYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)