Skip to content

Remove restrictive broadcastability check in local_blockwise_alloc #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 7, 2024

Description

This is very similar in flavor to #742

I'm a bit weary of the fact broadcastability can be redefined by our rewrites, specially after user graph manipulations, because it can mean some graphs may allow broadcasting depending on whether certain rewrites happen or not, and these should be static!

I think the proper solution will come through #408, so that we can both know something has shape 1 and is or is not allowed to broadcast

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (b79d232) to head (abb646f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   80.80%   80.80%   -0.01%     
==========================================
  Files         162      162              
  Lines       46815    46814       -1     
  Branches    11453    11453              
==========================================
- Hits        37831    37830       -1     
  Misses       6735     6735              
  Partials     2249     2249              
Files Coverage Δ
pytensor/tensor/rewriting/blockwise.py 94.79% <ø> (-0.06%) ⬇️

@ricardoV94 ricardoV94 merged commit 146a0a8 into pymc-devs:main May 7, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant