Allow fill_sink rewrite to accomodate changes in broadcastability

[ricardoV94]

Description

The strict assumption that one of the existing variables could make the rewritten output broadcastable pattern match the original one, led to a failure in pymc-devs/pymc#7327 (https://github.com/pymc-devs/pymc/actions/runs/9253581078/job/25453566092?pr=7327#step:7:265)

This is related to #408, the sooner we fix that the better, as this kind of problems keep popping all the time, and makes graph subject to changes in behavior depending on whether rewrites are performed or not

Related Issue

• Closes #
• Related to #

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

[ricardoV94]

Should graph_replace (which is the way this "mis-behaved" graph was created in the PyMC test) rebuild the downstream graph when strict=False and the new inputs have different static types (like clone_replace does?). IIRC we changed from using graph_replace to clone_replace in nutpie because graph_replace was not doing this?

Had it rebuild the downstream nodes, the problem wouldn't have shown up (I still like the new rewrite code better).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.85%. Comparing base (5f374db) to head (2615da0).
Report is 210 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #785   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files         162      162           
  Lines       47045    47043    -2     
  Branches    11514    11514           
=======================================
- Hits        38039    38038    -1     
  Misses       6750     6750           
+ Partials     2256     2255    -1     

Files	Coverage Δ
pytensor/tensor/rewriting/basic.py	93.89% <100.00%> (+0.14%)	⬆️

... and 1 file with indirect coverage changes

[aseyboldt]

Sounds good!