-
Notifications
You must be signed in to change notification settings - Fork 132
Add nan_to_num
helper
#796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -95,6 +95,7 @@ | |||||
minimum, | ||||||
mod, | ||||||
mul, | ||||||
nan_to_num, | ||||||
neg, | ||||||
neq, | ||||||
outer, | ||||||
|
@@ -3641,3 +3642,31 @@ def test_grad_n_undefined(self): | |||||
n = scalar(dtype="int64") | ||||||
with pytest.raises(NullTypeGradError): | ||||||
grad(polygamma(n, 0.5), wrt=n) | ||||||
|
||||||
|
||||||
@pytest.mark.parametrize( | ||||||
["nan", "posinf", "neginf"], | ||||||
[(0, None, None), (0, 0, 0), (0, None, 1000), (3, 1, -1)], | ||||||
) | ||||||
def test_nan_to_num(nan, posinf, neginf): | ||||||
x = tensor(shape=(7,)) | ||||||
|
||||||
out = nan_to_num(x, nan, posinf, neginf) | ||||||
|
||||||
f = function( | ||||||
[x], | ||||||
nan_to_num(x, nan, posinf, neginf), | ||||||
on_unused_input="warn", | ||||||
allow_input_downcast=True, | ||||||
) | ||||||
|
||||||
y = np.array([1, 2, np.nan, np.inf, -np.inf, 3, 4]) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would solve the failing float32 test without having to downcast the input
Suggested change
|
||||||
out = f(y) | ||||||
|
||||||
posinf = np.finfo(x.real.dtype).max if posinf is None else posinf | ||||||
neginf = np.finfo(x.real.dtype).min if neginf is None else neginf | ||||||
|
||||||
np.testing.assert_allclose( | ||||||
out, | ||||||
np.nan_to_num(y, nan=nan, posinf=posinf, neginf=neginf), | ||||||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these custom Ops, or can we just use helper functions like
nan_to_num
such aspt.eq(x, -np.inf)
?In general we want to have as little Ops as possible, and just reuse what we already have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just referred to this conversation and implemented the two ops. This can be done even without them. Should I omit these in the next commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, no new Ops is always the default and preferred strategy