Skip to content

Improved docstrings for Elemwise functions#830

Closed
fonnesbeck wants to merge 0 commit intopymc-devs:mainfrom
fonnesbeck:main
Closed

Improved docstrings for Elemwise functions#830
fonnesbeck wants to merge 0 commit intopymc-devs:mainfrom
fonnesbeck:main

Conversation

@fonnesbeck
Copy link
Member

@fonnesbeck fonnesbeck commented Jun 18, 2024 •
edited
Loading

Description

Added more robust docstrings and removed the Elemwise docstring that was appended to each function.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@fonnesbeck fonnesbeck requested a review from ricardoV94 June 18, 2024 03:11
ricardoV94
ricardoV94 reviewed Jun 18, 2024
View reviewed changes
ricardoV94
ricardoV94 reviewed Jun 18, 2024
View reviewed changes
ricardoV94
ricardoV94 reviewed Jun 18, 2024
View reviewed changes
ricardoV94
ricardoV94 reviewed Jun 18, 2024
View reviewed changes
ricardoV94
ricardoV94 reviewed Jun 18, 2024
View reviewed changes
@fonnesbeck
Copy link
Member Author

fonnesbeck commented Jun 18, 2024

Not clear why the fast-compile tests are failing here.

@fonnesbeck fonnesbeck requested a review from ricardoV94 June 18, 2024 14:57
@ricardoV94
Copy link
Member

ricardoV94 commented Jun 19, 2024

Not clear why the fast-compile tests are failing here.

Something must have actually broken. Perhaps the Elemwise decorator was doing something dumb that fails with the new docstrings? Have to investigate

@ricardoV94 ricardoV94 added the docs label Oct 7, 2024
@ricardoV94 ricardoV94 changed the title Improved docstrings for user-facing functions Improved docstrings for Elemwise functions Oct 7, 2024
@fonnesbeck fonnesbeck closed this Dec 17, 2024
This was referenced Feb 26, 2025
Closed
Merged
@twiecki
Copy link
Member

twiecki commented Feb 27, 2025

It seems by force-pushing you removed all commits @fonnesbeck. are they still to be found somewhere?

@ricardoV94
Copy link
Member

ricardoV94 commented Feb 27, 2025

Oh :(

@fonnesbeck
Copy link
Member Author

fonnesbeck commented Feb 27, 2025

Yeah, I never got around to re-doing this PR. I can work on it this week.

@ricardoV94
Copy link
Member

ricardoV94 commented Feb 27, 2025 •
edited
Loading

Yeah, I never got around to re-doing this PR. I can work on it this week.

We wanted to see if Claude could figure it out. But we need your changes :)

@fonnesbeck fonnesbeck mentioned this pull request Feb 28, 2025
Merged
11 tasks
@twiecki twiecki mentioned this pull request Mar 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardoV94 ricardoV94 Awaiting requested review from ricardoV94

Assignees

No one assigned

Labels

docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DOC: Docstrings for Elemwise Ops are not very helpful

3 participants

@fonnesbeck @ricardoV94 @twiecki