-
Notifications
You must be signed in to change notification settings - Fork 129
Added rewrites involving block diagonal matrices #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jessegrabowski
merged 4 commits into
pymc-devs:main
from
tanish1729:rewrite_diag_blockdiag
Oct 8, 2024
Merged
Added rewrites involving block diagonal matrices #967
jessegrabowski
merged 4 commits into
pymc-devs:main
from
tanish1729:rewrite_diag_blockdiag
Oct 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You need to rebase. |
8b2ef28
to
bc30db8
Compare
jessegrabowski
requested changes
Aug 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
==========================================
+ Coverage 81.73% 81.74% +0.01%
==========================================
Files 182 182
Lines 47633 47663 +30
Branches 11604 11622 +18
==========================================
+ Hits 38934 38964 +30
+ Misses 6509 6507 -2
- Partials 2190 2192 +2
|
9857f0f
to
fa7d9da
Compare
jessegrabowski
approved these changes
Oct 8, 2024
Ch0ronomato
pushed a commit
to Ch0ronomato/pytensor
that referenced
this pull request
Nov 2, 2024
* added rewrite for diag(block_diag) * added rewrite for determinant of blockdiag * Added rewrite for slogdet; added docstrings for all 3 rewrites * fixed typecasting for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the following rewrites :
Related Issue
Checklist
Type of change