minval and maxval for float32 in simulator

[RyIot3329]

Versions

• Python: Python 3.9.2
• OS: Debian 11
• Pymodbus: dev

Pymodbus Specific

• Server: tcp - Simulator

Description

I have this defined in my json file for the simulator.

    {
      "addr": [7, 8],
      "value": 72.0,
      "action": "random",
      "kwargs": { "minval": 65.0, "maxval": 78.0 }
    }

It does not seem to follow the minval and maxval values from what I can see. I am getting random Float values, so that works. But it isn't in between the bounds. Any ideas?

[janiversen]

datastore/simulator.py#633 it seems to do what it is supposed to do.

I need to check it.

[janiversen]

I see it's not covered in our test suite, I will add a specific test and see what happens.

[janiversen]

I have now added a test case, and as far as I can see everything works as it should.

Did you make the configuration within the "float32" label ?

I added your values just to test. The test case retrieves 100 values and all are between minval and maxval.

If you need further help, please add the pymodbus debug log, as the issue template asked you to do.

[RyIot3329]

Yeah I added it within the "float" block. Would it help to upload the entire json file?

[janiversen]

No, a debug log would help.

[RyIot3329]

Sorry for the delay on this. Here is the log file and the JSON file I am using
log.txt
tstat.txt