-
Notifications
You must be signed in to change notification settings - Fork 1k
Proof transport reconnect works. #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b337c2e to
95476f8
Compare
|
@alexrudd2 I know why pytest passed, that is being corrected here, and I will use this PR to chase down
|
95476f8 to
f5243a2
Compare
|
@alexrudd2 seems my understanding also needs some updating 🥇 this is going to be interesting. Actually I might try to avoid the call_later at all, use create_task and sleep in the method. |
96f7c46 to
1c4e509
Compare
|
First reconnect now works nice, but second reconnect never happens...something about the tasks. |
https://github.com/numat/midas/actions/runs/5159705871/jobs/9294966924#step:7:24 My test does not fully fail, but if you expand the |
1c4e509 to
37ecf2c
Compare
|
Thanks, I am hopeful that its all solved now. |
|
@alexrudd2 please try dev, when you have time...if everything works for you, I can cut a release 3.3.1 in a couple of days. |
The latest I still do not understand, but thank you! :) |
I back ported a part from #1572 in order to keep life simple.
Add new test file test_reconnect.py to verify reconnect.
closes #1574