Skip to content

fix getFrameStart for ExceptionResponse #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janiversen merged 2 commits into from
Jun 23, 2023
Merged

fix getFrameStart for ExceptionResponse #1627

janiversen merged 2 commits into from
Jun 23, 2023

Conversation

@Fredo70
Copy link
Contributor

@Fredo70 Fredo70 commented Jun 23, 2023

No description provided.

janiversen
janiversen approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this might also be present in the other frame handler. Do you mind checking?

@janiversen janiversen changed the title fix getFrameStart if response is ExceptionResponse fix getFrameStart for ExceptionResponse Jun 23, 2023
@janiversen
Copy link
Collaborator

janiversen commented Jun 23, 2023 •
edited
Loading

If you run with our venv (see README.RST) then most things are caught in precommit.

For mypy etc run ./check_ci.sh

This is just a suggestion if you get tired of CI.

@janiversen janiversen merged commit b0c0b62 into pymodbus-dev:dev Jun 23, 2023
@Fredo70
Copy link
Contributor Author

Fredo70 commented Jun 25, 2023

this might also be present in the other frame handler. Do you mind checking?

I'm not sure. I didn't see this construct in the other Framers.

@Fredo70
Copy link
Contributor Author

Fredo70 commented Jun 25, 2023

If you run with our venv (see README.RST) then most things are caught in precommit.

Unfortunately, I develop under Windows. I already have an old Linux laptop somewhere. But it's too slow.
I have to write down that I have to keep these things in mind. I like to be forgetful ;-)

@janiversen
Copy link
Collaborator

janiversen commented Jun 26, 2023

Python is the same on windows command line, The only script we have is check_ci.sh and that is just a few python commands.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fredo70 @janiversen