Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If you check how you're handling writing to multiple registers, you notice you're using explicit
is Nonecheck, which allows passing "falsy" values.However for coils, you're doing
notcheck, which means it's impossible to write0as it will get converted to an emptylist.It's not a big deal and it's a good practice to explicitly wrap values into a list, but since you do support it for input registers, can make sense to support for coils as well.
Changelog:
notcheck with explicitis NoneNote:
I'm not too familiar with
pytest, but I hope I added a valid test case for this.