Skip to content

Fix #1746 . Return missing result #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 1 commit into from
Aug 26, 2023
Merged

Fix #1746 . Return missing result #1748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pymodbus/repl/client/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def _print_command_help(self, commands):
)
)

def _process_client(self, text, client):
def _process_client(self, text, client) -> Result:
"""Process client commands."""
text = text.strip().split()
cmd = text[0].split(".")[1]
Expand All @@ -209,6 +209,7 @@ def _process_client(self, text, client):
else:
result = Result(getattr(client, cmd)(**kwargs))
result.print_result()
return result

def _process_result(self, text, result):
"""Process result commands."""
Expand All @@ -233,7 +234,7 @@ def run(self):
elif text.strip().lower() == "exit":
raise EOFError()
elif text.strip().lower().startswith("client."):
self._process_client(text, self.client)
result = self._process_client(text, self.client)
elif text.strip().lower().startswith("result.") and result:
self._process_result(text, result)
except KeyboardInterrupt:
Expand Down