Remove pre-commit #1860
Merged
Remove pre-commit #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
force-pushed
the
no_precommit
branch
4 times, most recently
from
1103c77 to
ffa93d5
Compare
janiversen
force-pushed
the
no_precommit
branch
from
ffa93d5 to
8439ab3
Compare
alexrudd2
approved these changes
Oct 27, 2023
Collaborator
alexrudd2
left a comment
alexrudd2
left a comment
There was a problem hiding this comment.
The execs is unnecessary in the hook script, but this works for me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no real advantage of using pre-commit in our setup.
It is being replaced by a manual git hook (located in githooks)
As a first step .pre-commit-config.yaml is reduced by removing all the duplicate checks.