Enable RUF013 (implicit optional) #1882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
requested changes
Nov 8, 2023
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
Seems this PR have a problem, we currently do not have on dev.
Collaborator
Author
Very strange, since there are no code changes. I think I manually deleted the Linux/3.8 cache and reran the workflow manually, and it fails. The tests also fail on my Mac. I will bisect. |
Collaborator
Author
|
Triaged as #1883 |
Collaborator
|
I just tested dev without cache, no problem on my computer. |
Collaborator
Author
(I think you realize this already, but your computer would have broken upon upgrading to Anyways, that is solved. I can merge when you re-review with approval. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent PRs eliminating implicit optional are now enough to satisfy
ruff(although not yetmypy)