Skip to content

Raise exception on no response in async client. #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janiversen merged 1 commit into from
Dec 13, 2024
Merged

Raise exception on no response in async client. #2502

janiversen merged 1 commit into from
Dec 13, 2024

Conversation

@philj56
Copy link
Contributor

@philj56 philj56 commented Dec 13, 2024

This makes the async client behave the same as the sync client again.

Fixes #2500.

@philj56
Raise exception on no response in async client.
f7440ba 
This makes the async client behave the same as the sync client again.
janiversen
janiversen approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks.

@janiversen janiversen merged commit 1c0fa4b into pymodbus-dev:dev Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janiversen janiversen janiversen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Async client functions return None on no response.

2 participants

@philj56 @janiversen