Flush recv_buffer before each transaction write. #2581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2025
janiversen
requested changes
Feb 22, 2025
pymodbus/transaction/transaction.py
Outdated
| ) | ||
| return response | ||
| except asyncio.exceptions.TimeoutError: | ||
| self.recv_buffer = b"" |
Collaborator
There was a problem hiding this comment.
This is the wrong place, since it can cause conflicts with the active callback.
It would be better placed in line 140, which is before the callback is active.
Contributor
Author
There was a problem hiding this comment.
Ah, yeah I guess purging the buffer before doing the write makes more sense.
Ensure we don't have any non-relevant data in the buffer.
jameshilliard
force-pushed
the
flush-recv-on-timeout
branch
from
db5f695 to
2d19884
Compare
jameshilliard
changed the title
janiversen
approved these changes
Feb 22, 2025
janiversen
pushed a commit
that referenced
this pull request
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we don't have any non-relevant data in the buffer.
Haven't tested yet but I think this is the expected behavior based on this comment.