Skip to content
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion pymodbus/client/mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -771,5 +771,20 @@ def convert_to_registers(
for x in range(0, len(byte_list), 2)
]
if word_order == "little":
regs.reverse()
return cls._get_reversed_registers(regs, data_type)

return regs

@classmethod
def _get_reversed_registers(cls, regs: list[int], data_type: DATATYPE) -> list[int]:
data_type_len = data_type.value[1]
if not data_type_len:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please combine the 2 lines using the := operator.

regs.reverse()
return regs

reversed_regs = []
for x in range(0, len(regs), data_type_len):
single_value_regs = regs[x: x + data_type_len]
single_value_regs.reverse()
reversed_regs = reversed_regs + single_value_regs
return reversed_regs