-
Notifications
You must be signed in to change notification settings - Fork 1k
Issue 2675 correctly reverse fixed size datatypes #2678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
janiversen
merged 8 commits into
pymodbus-dev:dev
from
igorbga:issue_2675_correctly_reverse_fixed_size_datatypes
Jun 3, 2025
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a7c3f5d
Make convert_to_registers reverse little endian words properly when c…
igorbga aee788f
Simplify method complexity
igorbga 11c9fd9
style change suggested by ci
igorbga 8adffd2
Use walrus operator instead of assigment followed by condition
igorbga 117f18d
Type hint improvement
igorbga e4586ba
Remove trailing whitespaces
igorbga bc32e33
Tests for convert_to_registers with support for multiple values at once
igorbga df69199
Remove unnecessary whitespaces
igorbga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please combine the 2 lines using the := operator.