Skip to content

Return 0x02 Illegal Data Address instead of 0x04 Server Device Failure #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexrudd2 wants to merge 3 commits into from
Closed

Return 0x02 Illegal Data Address instead of 0x04 Server Device Failure #2717

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2d40de
Return 0x02 Illegal Data Address instead of 0x04 Server Device Failure
alexrudd2 Aug 6, 2025
777fae9
Use a custom Exception instead of broad KeyError
alexrudd2 Aug 8, 2025
d199c5e
Merge branch 'dev' into issue-2716
janiversen Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pymodbus/server/requesthandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ async def handle_request(self):
if self.server.ignore_missing_devices:
return # the client will simply timeout waiting for a response
response = ExceptionResponse(self.last_pdu.function_code, ExceptionResponse.GATEWAY_NO_RESPONSE)
except KeyError:
Copy link
Collaborator

@janiversen janiversen Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not generic, problems in the sparse datastore, should be solved at that level.

keyError can probably mean different things in the different datastores.

Look at simulator.py around line 587, to see how it is handled there (apart from the ugly constant 2).

Log.error("Requested register address does not exist: {}", self.last_pdu.address)
response = ExceptionResponse(self.last_pdu.function_code, ExceptionResponse.ILLEGAL_ADDRESS)
except Exception as exc: # pylint: disable=broad-except
Log.error(
"Datastore unable to fulfill request: {}; {}",
Expand Down