Skip to content

Fixed typo #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed typo #188

wants to merge 1 commit into from

Conversation

@DaniilOkladnikov
Copy link

@DaniilOkladnikov DaniilOkladnikov commented Oct 13, 2023 •
edited
Loading

Typo aca_element = element.find("ControllerAction/ActivateControllerAction"), here .xosc file:

          <PrivateAction>
            <ActivateControllerAction lateral="true" longitudinal="true" />
          </PrivateAction>

@mander76
Copy link
Collaborator

mander76 commented Oct 16, 2023

Hi, thanks for the pullrequest, this might work for some cases, but ActivateControlleraction is different in different versions of OpenSCENARIO, in 1.0 it is not in a ControllerAction, so this will cause a problem.

@atingber
Copy link
Collaborator

atingber commented May 21, 2024

What problem does this solve?

@atingber atingber added the question Further information is requested label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

question Further information is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DaniilOkladnikov @mander76 @atingber