Skip to content

fix(tests): manylinux images moved to gcc-toolset-15#664

Draft
mayeut wants to merge 3 commits intopypa:mainfrom
mayeut:manylinux-update
Draft

fix(tests): manylinux images moved to gcc-toolset-15#664
mayeut wants to merge 3 commits intopypa:mainfrom
mayeut:manylinux-update

Conversation

@mayeut
Copy link
Member

@mayeut mayeut commented Jan 3, 2026

No description provided.

@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.24%. Comparing base (78e3a6f) to head (56b4f1d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files          22       22           
  Lines        1829     1829           
  Branches      343      343           
=======================================
  Hits         1742     1742           
  Misses         48       48           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mayeut mayeut marked this pull request as draft January 3, 2026 13:24
@mayeut
Copy link
Member Author

mayeut commented Jan 3, 2026

the new gcc-toolset will be reverted shortly in manylinux: pypa/manylinux#1900
just one analysis done on tests/integration/test_manylinux.py::TestManylinux::test_rpath[manylinux_2_28-rpath]:
segfaults when calling init on a grafted library.

LD_DEBUG=libs python '-c' 'from testrpath import testrpath; print(testrpath.func())'
...
       470:	calling init: /opt/python/cp310-cp310/lib/python3.10/site-packages/testrpath/../testrpath.libs/libb-1c566650.so
       470:	
Segmentation fault (core dumped)

The assembly for this simple lib is the same between gcc-14 & gcc-15, the difference appears once linked as a shared library (the disassembly for the shared object is also the same for both versions except for offsets).

@mayeut
Copy link
Member Author

mayeut commented Jan 4, 2026

The issue with patchelf 0.17.2 is likely the same as NixOS/patchelf#568
There's no released version of patchelf with NixOS/patchelf#544
It might be time to revisit #174
repairwheel patcher works on that test case
lief-patchelf patcher from LIEF works on that test case as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant