Enforce mypy on all Core bandersnatch #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set Python 3.6 - Turn on a lot more mypy checks + warnings - Exclude all plugins for now and focus on main code base
cooperlees
commented
May 31, 2020
Comment on lines
+51
to
+53
| with importlib.resources.path( # type: ignore | ||
| "bandersnatch", "default.conf" | ||
| ) as config_path: |
There was a problem hiding this comment.
@SanketDG - Any ideas why this error occurs? I haven't dug into it ... Maybe because in 3.6 we use the pulled in dependency?
I might move 4.1 to be >= 3.7.0 since Docker containers make moving to newer python so much easier these days ...
There was a problem hiding this comment.
Yup, the library does not seem to have type hints
https://gitlab.com/python-devs/importlib_metadata/-/issues/10
| @@ -97,7 +97,7 @@ def rewrite( | |||
| self.delete_file(filepath_tmp) | |||
|
|
|||
| @contextlib.contextmanager | |||
| def update_safe(self, filename: str, **kw: Any) -> Generator[IO, None, None]: | |||
| def update_safe(self, filename: PATH_TYPES, **kw: Any) -> Generator[IO, None, None]: | |||
There was a problem hiding this comment.
@techalchemy - This should be legit - my quick looks seems both can be handled or am I missing something?
There was a problem hiding this comment.
Dan ok'd in IRC. Merging :D
cooperlees
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work to get closer to finally close #15