type annotate plugin tests

[rkm]

this finishes-off the test annotations and closes #15! I also refactored-out the mock_config function that was duplicated in a few places -- hope that's ok.

I was having trouble running pre-commit through tox locally, so ended up missing black & flake8 in my commits until the end -- you may want to squash-merge.

[codecov]

Codecov Report

Merging #593 into master will increase coverage by 0.04%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
+ Coverage   79.05%   79.10%   +0.04%     
==========================================
  Files          13       13              
  Lines        2053     2053              
  Branches      293      293              
==========================================
+ Hits         1623     1624       +1     
+ Misses        322      321       -1     
  Partials      108      108              

Impacted Files	Coverage Δ
src/bandersnatch_storage_plugins/swift.py	70.89% <50.00%> (+0.13%)	⬆️
src/bandersnatch/filter.py	100.00% <100.00%> (ø)
src/bandersnatch/storage.py	71.42% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fc2a8...5a91f04. Read the comment docs.

[cooperlees]

Thanks for removing the duplicate code! This is awesome.

[cooperlees]

Would love to know why tox was unable to run pre-commit or work - What was the error? can you open an issue?

[rkm]

Thanks for the merge! Hope I can help out more in future.

Would love to know why tox was unable to run pre-commit or work - What was the error? can you open an issue?

It was due to something broken in my local environment which I wasn't able to track down. I blew away my local pip and pre-commit caches and it worked again though. Not sure there's enough info there for a bug report unfortunately!