Skip to content

Conversation

@hauntsaninja
Copy link
Contributor

Suggested in #1342

@Czaki
Copy link
Contributor

Czaki commented Nov 22, 2022

could this be used in repair-wheel-command? If Yes, then maybe suggest this in docs?

@hauntsaninja
Copy link
Contributor Author

hauntsaninja commented Nov 22, 2022

I think specifying it in repair-wheel-command would override the default of running auditwheel / delocate-wheel instead of running abi3audit in addition, which would be undesirable? I guess you could chain with && but then you'd have to specify the platform overrides that cibuildwheel otherwise takes care of for you.

@henryiii
Copy link
Contributor

You'd want to && them (or make a TOML list).

@henryiii
Copy link
Contributor

It would be another example here: https://cibuildwheel.readthedocs.io/en/stable/options/#repair-wheel-command

(we used to have a mutli-line option there before, it would be nice to have an example like that again)

@hauntsaninja
Copy link
Contributor Author

Unless I'm messing up how I'm running abi3audit, I think this is blocked on pypa/abi3audit#23

@joerick
Copy link
Contributor

joerick commented Dec 4, 2022

Looks like that issue was fixed - are you able to incorporate the above @hauntsaninja ?

@hauntsaninja hauntsaninja requested a review from joerick December 5, 2022 21:32
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@joerick joerick merged commit c8a2671 into pypa:main Dec 11, 2022
@hauntsaninja hauntsaninja deleted the abi3audit branch December 11, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants