feat: remove 32-bit linux from auto arch, fix auto32 on linux aarch64 #2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/feat/autorework
branch
3 times, most recently
from
2c79987 to
51bc714
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the architecture configuration logic by removing 32‑bit Linux architectures from the default "auto" option and refining the behavior of "auto32" on Linux (particularly on aarch64) while updating test cases, documentation, and the pre-commit configuration accordingly.
- Update tests to expect only 64‑bit Linux archs by default.
- Refactor Architecture.parse_config and Architecture.bitness_archs using match‑case to correctly map auto and native architectures.
- Revise documentation and pre-commit configuration to align with the new behavior.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| unit_test/options_test.py | Added explicit arch list "auto64", "auto32" in test configurations. |
| unit_test/option_prepare_test.py | Updated test environment to set CIBW_ARCHS reflecting new arch behavior. |
| unit_test/main_tests/main_platform_test.py | Adjusted expected auto architectures for Linux. |
| unit_test/architecture_test.py | Modified tests for auto arch parsing, including aarch32 condition. |
| test/utils.py | Added a new full_auto parameter to conditionally build both arch wheels. |
| docs/options.md | Updated option descriptions, tables, warnings, and notes regarding auto archs. |
| cibuildwheel/architecture.py | Refactored config parsing with match‑case and updated bitness logic. |
| README.md | Updated checksum metadata. |
| .pre-commit-config.yaml | Updated cogapp dependency version. |
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/autorework
branch
from
51bc714 to
9c411c2
Compare
joerick
reviewed
Jun 10, 2025
Contributor
joerick
left a comment
joerick
left a comment
There was a problem hiding this comment.
Big thanks for putting this together. Looks good to me, just a couple notes.
Co-authored-by: Joe Rickerby <[email protected]>
henryiii
commented
Jun 10, 2025
Contributor
|
The Azure failure is:
|
Contributor
|
I raised a PR for that - #2461 . |
joerick
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposal (option 2), close #2451.