-
Notifications
You must be signed in to change notification settings - Fork 294
Updates for Pyodide 0.28 release #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
cdae9e2
58c8c04
39282c8
381dbd5
3ebe89e
5f32950
7ac9967
3eb8d73
e616c3f
5ee499b
6bf8027
7e909d7
bda44b8
70b35d0
095176b
b19e9dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,10 +99,17 @@ def __call__(self, build_id: str) -> bool: | |
| return False | ||
| if EnableGroup.GraalPy not in self.enable and fnmatch(build_id, "gp*"): | ||
| return False | ||
| if EnableGroup.PyodidePrerelease not in self.enable and fnmatch( | ||
| build_id, "cp313-pyodide_*" | ||
| ): | ||
| return False | ||
| # TODO: Re-enable this when we have Pyodide prereleases again (e.g., 0.29.0a1+) | ||
| # Python 3.13 support became stable in Pyodide 0.28.0, so it no longer needs a prerelease | ||
| # flag. | ||
| # Also update Pyodide tests in unit_test/build_selector_test.py accordingly. | ||
| # When re-enabling, update the pattern to match the experimental Python version in case | ||
| # it is bumped to Python 3.14 (likely cp314-pyodide_* but could remain as 3.13 as well). | ||
| # This depends on the CPython version being used in the Pyodide runtime at the time. | ||
| # if EnableGroup.PyodidePrerelease not in self.enable and fnmatch( | ||
| # build_id, "cp313-pyodide_*" | ||
| # ): | ||
| # return False | ||
|
Comment on lines
+102
to
+112
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure what the best way to handle this would be. We don't have a Pyodide 0.29.0 pre-release yet because it's too early to have one. We usually stay one year behind CPython version compatibility, allowing our packages to complete their upgrades. The We currently say that "If there are pre-releases available for a newer Pyodide version, the We could document there that
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm personally okay with the commenting approach above. As for the other points, yeah, I can see that it might get a little awkward around alphas, but that's probably okay, that's what alphas are for :) @henryiii were discussing some ideas in #2448 about the possibility of being able to add new identifiers at runtime, which might help? Having said that, I think we're gonna continue to want the python version in the identifier to support the functionality of the requires-python feature. |
||
|
|
||
agriyakhetarpal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| should_build = selector_matches(self.build_config, build_id) | ||
| should_skip = selector_matches(self.skip_config, build_id) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.