Skip to content

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Aug 12, 2025

This adds "patchelf" on platforms where Android wheels can be built, since it's required. It's not added on platforms where a binary isn't available, which shouldn't be building Android wheels either.

The alternative is to just require users to pre-install it, which isn't bad, but I think this is nicer?

See pybind/pybind11#5714 (comment).

@henryiii henryiii merged commit ff9a284 into pypa:main Aug 13, 2025
28 checks passed
@henryiii henryiii deleted the henryiii/fix/androidreq branch August 13, 2025 12:52
@henryiii
Copy link
Contributor Author

@mhsmith, it looks like we are getting Error: cibuildwheel: Couldn't find 'patchelf' in PATH when running on macOS (https://github.com/pybind/pybind11/actions/runs/17138877560/job/48621564021?pr=5809), maybe we should see if patchelf is installed alongside cibuildwheel and then use it from there if it was present?

@mhsmith
Copy link
Member

mhsmith commented Aug 22, 2025

Yes, this is the same issue we previously had with wheel: the cibuldwheel GitHub action runs cibuildwheel without activating the environment, so the environment's bin directory isn't on the PATH. I'll deal with this in #2568.

@mhsmith mhsmith mentioned this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants