Skip to content

Conversation

@timfel
Copy link
Contributor

@timfel timfel commented Sep 17, 2025

No description provided.

@timfel timfel force-pushed the tim/update-graalpy branch 3 times, most recently from 4015449 to 3b972fb Compare September 17, 2025 12:42
@timfel timfel added the CI: GraalPy Run the integration test suite with GraalPy included label Sep 17, 2025
@timfel timfel requested a review from mayeut September 18, 2025 09:08
@joerick
Copy link
Contributor

joerick commented Sep 20, 2025

Hm, I still see lots of workarounds...! I had expected them to go for some reason, maybe because of how the comments were worded. I'm wondering - did you expect to have a fix release out for GP24 or did I misunderstand?

@joerick
Copy link
Contributor

joerick commented Sep 21, 2025

But yeah, otherwise LGTM!

@timfel
Copy link
Contributor Author

timfel commented Sep 22, 2025

Hm, I still see lots of workarounds...! I had expected them to go for some reason, maybe because of how the comments were worded. I'm wondering - did you expect to have a fix release out for GP24 or did I misunderstand?

I had hoped to have a fix for GP24, but we couldn't get it out and for reasons I have no control over there will not be another release off the GP24 branch, so the workarounds have to stay for that version. Once we decide to drop it, we can remove them entirely. I wouldn't mind dropping it before we release the next version in the spring of next year, i just didn't want to do it without any overlap time in case someone did use a build spec with gp24 in it.

@timfel
Copy link
Contributor Author

timfel commented Sep 22, 2025

Hm, both the iOS as well as the windows tests seem flaky. They failed, they passed, they failed two times now... this PR shouldn't affect iOS tests, and the Windows tests seem to fail with network connectivity issues (the latest one running on CPython 3.8 afaict, so also not GraalPy related).

@joerick
Copy link
Contributor

joerick commented Sep 22, 2025

Yeah, the iOS tests being flaky is a known issue. The windows failure is test_ssl again, which honestly, I have no idea why it's such a problem child. It does hit the network, but then again, every build hits PyPI, and that's the one that has the problem.

I added a flaky marker, but maybe it needs a pause to get around temporary network issues.

@joerick joerick merged commit 7a67c6b into pypa:main Sep 22, 2025
72 of 78 checks passed
@timfel timfel deleted the tim/update-graalpy branch September 23, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: GraalPy Run the integration test suite with GraalPy included

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants