-
Notifications
You must be signed in to change notification settings - Fork 294
fix: support Docker 29 #2660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support Docker 29 #2660
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
joerick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice trick with object_pairs_hook! I'd like to get a quick release out with this, I expect more will hit the error as the Docker update rolls out.
Signed-off-by: Henry Schreiner <[email protected]>
|
I made a small tweak, I was going to add an underscore, then decided to just move it into a lambda to skip typing. Also matched the test to the actual output of Docker 29. |
|
Are you thinking minor, patch, or back ported patch? Here's a ChatGPT summary of the git log since 3.2.1. Lightly edited. 🚀 New Features
🐛 Fixes
🧹 Chores and Refactors
🧾 Documentation Updates
Overall: |
|
Thanks for that. Yeah, we're due a minor release, so I'm that way inclined - unless there's anything you'd like to get into the next feature release? edit: anything in the open PR queue, that is. |
|
Well, the uv building one is pretty close to passing, but to do it properly, I'll need to also make sure we handle multiple wheels being output, so I don't think it's that close. The uv iOS one requires changes in uv (possibly ones that have been just merged, but not in a release yet). So none close enough for me. There's also a Rust cross-compile PR that looks pretty simple, if @mhsmith approves of that, I think it could go in. |
|
thanks. putting the release together now. |
|
Released! |
|
Good, made the SchemaStore PR: SchemaStore/schemastore#5133 |
|
Thanks for the quick fix! 🍰 |
Lowering the case of the keys when reading the json file to support arbitrary
Api/APIchanges. Fix #2659.