fix: produce working SDists, check in CI #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
Oct 26, 2021
Comment on lines
+1
to
+6
| recursive-include cibuildwheel *.cfg | ||
| recursive-include cibuildwheel *.in | ||
| recursive-include cibuildwheel *.py | ||
| recursive-include cibuildwheel *.toml | ||
| recursive-include cibuildwheel *.txt | ||
| recursive-include cibuildwheel *.typed |
Contributor
Author
There was a problem hiding this comment.
This also could be written this way
Suggested change
| recursive-include cibuildwheel *.cfg | |
| recursive-include cibuildwheel *.in | |
| recursive-include cibuildwheel *.py | |
| recursive-include cibuildwheel *.toml | |
| recursive-include cibuildwheel *.txt | |
| recursive-include cibuildwheel *.typed | |
| recursive-include cibuildwheel *.cfg *.in *.py *.toml *.txt *.typed |
Contributor
There was a problem hiding this comment.
Either way seems fine to me, I'm more familiar with the multi-line version so maybe let's go with that
henryiii
changed the title
joerick
approved these changes
Oct 26, 2021
Contributor
joerick
left a comment
joerick
left a comment
There was a problem hiding this comment.
Looks good. I didn't know about check-manifest, handy tool!
Comment on lines
+1
to
+6
| recursive-include cibuildwheel *.cfg | ||
| recursive-include cibuildwheel *.in | ||
| recursive-include cibuildwheel *.py | ||
| recursive-include cibuildwheel *.toml | ||
| recursive-include cibuildwheel *.txt | ||
| recursive-include cibuildwheel *.typed |
Contributor
There was a problem hiding this comment.
Either way seems fine to me, I'm more familiar with the multi-line version so maybe let's go with that
Contributor
Author
|
Like every other handy tool: https://scikit-hep.org/developer/style It is setuptools only, so I haven’t been as active in ensuring that it gets added everywhere as I probably should be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported in #892 by ensuring the SDist is not missing files.