Skip to content

feat: include size in the final printout #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayeut merged 4 commits into from
Jan 4, 2022
Merged

feat: include size in the final printout #975

mayeut merged 4 commits into from
Jan 4, 2022

Conversation

@mayeut
Copy link
Member

@mayeut mayeut commented Dec 29, 2021

Fixes #734

It uses kB unconditionally.

e.g.

13 wheels produced in 9 minutes:
  spam-0.1.0-cp310-cp310-macosx_10_9_universal2.whl  4 kB
  spam-0.1.0-cp310-cp310-macosx_10_9_x86_64.whl      3 kB
  spam-0.1.0-cp310-cp310-macosx_11_0_arm64.whl       3 kB
  spam-0.1.0-cp36-cp36m-macosx_10_9_x86_64.whl       3 kB
  spam-0.1.0-cp37-cp37m-macosx_10_9_x86_64.whl       3 kB
  spam-0.1.0-cp38-cp38-macosx_10_9_universal2.whl    4 kB
  spam-0.1.0-cp38-cp38-macosx_10_9_x86_64.whl        3 kB
  spam-0.1.0-cp38-cp38-macosx_11_0_arm64.whl         3 kB
  spam-0.1.0-cp39-cp39-macosx_10_9_universal2.whl    4 kB
  spam-0.1.0-cp39-cp39-macosx_10_9_x86_64.whl        3 kB
  spam-0.1.0-cp39-cp39-macosx_11_0_arm64.whl         3 kB
  spam-0.1.0-pp37-pypy37_pp73-macosx_10_9_x86_64.whl 3 kB
  spam-0.1.0-pp38-pypy38_pp73-macosx_10_9_x86_64.whl 4 kB

@mayeut
Copy link
Member Author

mayeut commented Dec 29, 2021

closing/re-opening to trigger CI again (PR started during PyPI outage)

@mayeut mayeut closed this Dec 29, 2021
@mayeut mayeut reopened this Dec 29, 2021
joerick
joerick reviewed Dec 30, 2021
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

joerick
joerick approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge whenever you're ready :)

@mayeut mayeut merged commit 45e5768 into pypa:main Jan 4, 2022
@mayeut mayeut deleted the report-size branch January 4, 2022 21:52
@neutrinoceros neutrinoceros mentioned this pull request Apr 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joerick joerick joerick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: include size in the final printout

2 participants

@mayeut @joerick