-
Notifications
You must be signed in to change notification settings - Fork 46
Closed
Description
Describe the bug
The m
ABI flag is missing on some systems. E.g. for CPython 3.7 on Windows, distlib.wheel.ABI
is cp37
when it should be cp37m
.
As a result, the wheel file produced by distlib.wheel.Wheel
cannot be installed on the system that produced it.
To Reproduce
import distlib.wheel
print(distlib.wheel.ABI)
import packaging.tags
print(next(packaging.tags.sys_tags()).abi)
distlib: cp37
packaging: cp37m
Expected behavior
On Python 3.7 and earlier, m
should be appended to the ABI string when the WITH_PYMALLOC
config variable is None
.
See the packaging
implementation here: https://github.com/pypa/packaging/blob/69f21513cac4e742863e286f37b46022bf938da8/packaging/tags.py#L147-L150
And compare it to what distlib
does now:
Lines 63 to 64 in 052787b
if sysconfig.get_config_var('WITH_PYMALLOC'): | |
parts.append('m') |
Environment
- Windows Server 2022
- Python 3.7.9
- distlib 0.3.4
Metadata
Metadata
Assignees
Labels
No labels