Preserve the executable bit from wheel contents #90
Conversation
This is a property of individual files in the wheel, and thus needs to be parsed by the `WheelSource`, and needs special handling in `WheelDestination`. It also needs to be propagated through the entire pipeline, since the information needs to be exchanged between the two components.
|
@pradyunsg This feature would be very helpful for a project I'm working on for $WORK. Thanks for the great |
|
May I know when will this fix be released? |
| import zipfile | ||
| from contextlib import contextmanager | ||
| from typing import BinaryIO, Iterator, List, Tuple, cast | ||
|
|
||
| import installer.records | ||
| import installer.utils | ||
|
|
||
| WheelContentElement = Tuple[Tuple[str, str, str], BinaryIO] | ||
| WheelContentElement = Tuple[Tuple[str, str, str], BinaryIO, bool] |
There was a problem hiding this comment.
YMMV, but when I add the third field, I tend to start wondering if it would be clearer with a dataclass rather than a tuple.
There was a problem hiding this comment.
Yea, I had the same thought too. :)
However, I want this to be decoupled such that the source can be implemented without a dependency on this package. I'm basically thinking that wheel would end up implementing this interface, in their public API, and then we'd have a nice amount of synergy.
Sometime next month. Most of my OSS time this month is gonna go into pip's release. |
This is a property of individual files in the wheel, and thus needs to be parsed
by the
WheelSource, and needs special handling inWheelDestination. It alsoneeds to be propagated through the entire pipeline, since the information needs
to be exchanged between the two components.
Closes #68