Skip to content

[manylinux1] backport build #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Conversation

henryiii
Copy link
Contributor

Followup to #941 for manylinux1.

@henryiii henryiii changed the title chore: backport build to manylinux1 [manylinux1] backport build Feb 28, 2021
@henryiii
Copy link
Contributor Author

henryiii commented Mar 2, 2021

This would be so much shorter if Python 2 was dropped. Why not drop Python 2 for manylinux1 as well? And drop Python 3.5 in May along with the other manylinuxes?

@mayeut mayeut merged commit ace8dc1 into pypa:manylinux1 Mar 3, 2021
@mayeut
Copy link
Member

mayeut commented Mar 3, 2021

@henryiii,

I'm not planning to do any more work on manylinux1 except bumping versions for updates. No new enhancements, no removals. Just basic support with feature freeze while waiting for EOL. We'll see how usage evolves by the end of the year and I can revisit this position at a later date depending on that.
Given you did the work for build, merging this enhancement hopping it won't get messy with dependabot.

@henryiii
Copy link
Contributor Author

henryiii commented Mar 3, 2021

I would think that Python 2 removed from manylinux1, and Python 3.5 removed in May. By not removing them, these are getting maintained longer that if removed now. Someone using Python 2 is supposed to be using a pinned manylinux{^1} version already, why not require it across all manylinuxs? It would be much easier to drop Python 2 support in tools like cibuildwheel if all manylinuxs have dropped it. More importantly to me, Python 3.5 will "live" much longer if it's not removed when removed from the other manylinuxes in a few months. It's better to maintain less!

@henryiii
Copy link
Contributor Author

henryiii commented Mar 3, 2021

PS: If you need me to, I'm happy to do a removal.

@henryiii henryiii deleted the manylinux1-build branch March 3, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants