Merged
Conversation
mayeut
force-pushed
the
drop-manylinux2010
branch
2 times, most recently
from
5adc5a8 to
36ee3c6
Compare
h-vetinari
reviewed
Jul 18, 2022
Comment on lines
3
to
5
|
|
||
| # Stop at any error, show all commands | ||
| set -exuo pipefail |
There was a problem hiding this comment.
Sounds like the rest of that file could be deleted too.
Member
Author
There was a problem hiding this comment.
Thanks for the suggestion.
The whole fixup-mirrors could be removed however:
- This line is not manylinux2010 specific so not removed. It's part of the skeleton of every script in here.
- I'd rather keep the file as it will be needed at some point (I'd rather have it kept around rather than dig through history).
mayeut
force-pushed
the
drop-manylinux2010
branch
2 times, most recently
from
d1cb305 to
3df9ca9
Compare
mayeut
force-pushed
the
drop-manylinux2010
branch
from
3df9ca9 to
f004f72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1281