[WIP] Reduce image size #210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That'd be nice, I'll keep that in mind. However, right now I'm only tracking the master branch with #182, so your PR would have to be merged first. |
|
@dolang, no rush on this of course. Since I saw the comments for the "hack", I just thought I'd give you a head's up on this if it gets merged. |
mayeut
force-pushed
the
shrink
branch
3 times, most recently
from
7393247 to
2bf5229
Compare
mayeut
force-pushed
the
shrink
branch
2 times, most recently
from
018eaab to
b73fef4
Compare
mayeut
force-pushed
the
shrink
branch
2 times, most recently
from
0f332de to
a90554b
Compare
mayeut
force-pushed
the
shrink
branch
5 times, most recently
from
b141063 to
24039ee
Compare
14 tasks
mayeut
force-pushed
the
shrink
branch
2 times, most recently
from
4446869 to
c6760f0
Compare
mayeut
force-pushed
the
shrink
branch
2 times, most recently
from
15832f8 to
31bcdef
Compare
mayeut
force-pushed
the
shrink
branch
2 times, most recently
from
156bb35 to
d302f15
Compare
OpenSSL & curl libraries are isolated from the system one & won't conflict with system tools.
|
While working on a similar PR for manylinux2010, I found some minor quirks that need resolving. |
|
Let's no waste energy on manylinux1, I close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st & 2nd commits provide a small improvement and are quite straightforward.
The 3rd commit allows around 60MB to be saved. It uses a shared library of OpenSSL rather than the static version. OpenSSL & curl shared libraries are isolated from system ones using patchelf to change soname and dependencies (as does auditwheel for manylinux wheels).
Overall, 74MB saved.