Skip to content

Consistent changelogs for all specs #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2023
Merged

Consistent changelogs for all specs #1464

merged 1 commit into from
Dec 22, 2023

Conversation

jeanas
Copy link
Contributor

@jeanas jeanas commented Dec 22, 2023 •
edited by github-actions bot
Loading

@jeanas jeanas requested a review from pfmoore December 22, 2023 15:46
@jeanas
Copy link
Contributor Author

jeanas commented Dec 22, 2023

@encukou

@jeanas jeanas force-pushed the standard-changelogs branch from cba9bb7 to c0f078d Compare December 22, 2023 15:50
webknjaz
webknjaz approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, but would like to get more opinions.

@brettcannon
Copy link
Member

I'm good with the change!

@pradyunsg
Copy link
Member

Clicking auto-merge eagerly on this since, IIUC, it'll wait on the outstanding reviews.

If it does not, apologies and please do review this post-merge and I (or @jeanas, should they be willing 😅) will address that feedback.

@pradyunsg pradyunsg added this pull request to the merge queue Dec 22, 2023
Merged via the queue into pypa:main with commit 0b7879f Dec 22, 2023
@jeanas jeanas deleted the standard-changelogs branch December 22, 2023 21:46
@jeanas
Copy link
Contributor Author

jeanas commented Dec 22, 2023

Clicking auto-merge eagerly on this since, IIUC, it'll wait on the outstanding reviews.

Well, you just merged the change, since it had already been approved by @webknjaz, @brettcannon and yourself (I don't understand GitHub well enough to tell what exactly the condition for auto-merge to trigger is). 🙂

If it does not, apologies and please do review this post-merge and I (or @jeanas, should they be willing 😅) will address that feedback.

Sure, I will happily apply further feedback (although I may have less time temporarily due to Christmas etc.).

@pradyunsg
Copy link
Member

I don't understand GitHub well enough to tell what exactly the condition for auto-merge to trigger is

Evidently, same. 😅

@webknjaz
Copy link
Member

The branch protection requires just one approval from anyone. So it goes through unless blocked. No biggie, though.

@jeanas jeanas mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@webknjaz webknjaz webknjaz approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

@pfmoore pfmoore Awaiting requested review from pfmoore

@willingc willingc Awaiting requested review from willingc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add changelogs to all standards
4 participants
@jeanas @brettcannon @pradyunsg @webknjaz