Skip to content

Update landing page #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2017
Merged

Update landing page #326

merged 7 commits into from
Jun 16, 2017

Conversation

theacodes
Copy link
Member

  • Use friendlier language
  • Be more authoritative
  • Briefly explain the various types of documentation here.

@theacodes theacodes requested review from ddbeck and ncoghlan June 15, 2017 23:47
@theacodes
Copy link
Member Author

Towards #317

Copy link
Member

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so once the build issue is resolved, I say go ahead and merge it :)

@ncoghlan
Copy link
Member

Taking a closer look at the build issue, it's just the reminder to update the reference set of deep links.

source/index.rst Outdated
The "Python Packaging User Guide" (PyPUG) aims to be the authoritative resource
on how to package, publish, and install Python projects using current tools.
Welcome to the *Python Packaging User Guide*. This guide provides documentation
on how to distribute and install Python packages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revised text here seems to be a lot less clear about what distinguishes this guide from, say, the setuptools or pip docs. If this text is going to change, I'd like to see it be even more reader focused. How about something like Welcome to the *Python Packaging User Guide*, a collection of tutorials and references to help you distribute and install Python packages. Or something like that. We can workshop it a bit. 😃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, updated. :)

source/index.rst Outdated

Additionally, there is a list of :doc:`other projects <key_projects>` maintained by members of the Python Packaging Authority.

Index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Index should be Contents

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

source/index.rst Outdated

.. _docs.python.org: http://docs.python.org
Get started
===========
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and the following headings) ought to be level 2.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are.

source/index.rst Outdated
To follow the development of Python packaging, see the `Python
Packaging Authority <https://www.pypa.io>`_.
This guide is maintained on `GitHub`_ by the `Python Packaging Authority`_. We
happily accept any :doc:`contributions and feedback <contribute>`. :)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gratuitous personal preference: change :) to 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

source/index.rst Outdated

If you want to learn how to package and distribute your projects, see the :doc:`tutorial on packaging and distributing <tutorials/distributing-packages>`

More resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the ToC below is going to show more depth, then I don't think this section is necessary. Skip right to the ToC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually want to try to hide the ToC on this page, gotta tweak the theme a bit to get that to work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, toc hidden, you can check it out here: http://temp.theadora.io/pypug-326/index.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'm not in love with not having the full ToC visible anywhere, but I'll cope. A couple more comments coming up, in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe retitle this section as "Learn more" for parallelism with "Get started"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

source/index.rst Outdated

If you want to learn how to package and distribute your projects, see the :doc:`tutorial on packaging and distributing <tutorials/distributing-packages>`

More resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'm not in love with not having the full ToC visible anywhere, but I'll cope. A couple more comments coming up, in this case.

source/index.rst Outdated

If you want to learn how to package and distribute your projects, see the :doc:`tutorial on packaging and distributing <tutorials/distributing-packages>`

More resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe retitle this section as "Learn more" for parallelism with "Get started"

source/index.rst Outdated
* :doc:`guides/index` that walk you through a specific task.
* :doc:`discussions/index` that provide comprehensive documentation on specific topics.
* :doc:`specifications/index` for detailed information about packaging specifications.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these bullets are going to signpost the rest of the ToC, let's be a little be a little more forthcoming about what these sections contain. How about something like this:

* :doc:`guides/index` for walk throughs, such as :doc:`guides/installing-using-linux-tools` or :doc:`guides/packaging-binary-extensions`
* :doc:`discussions/index` for in-depth references on topics such as :doc:`discussions/deploying-python-applications` or :doc:`discussions/pip-vs-easy-install`
* :doc:`specifications/index` for packaging interoperability specifications

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing: can we lose the periods on the ends of the bullets? It's a list of things, not really completely sentences

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

source/index.rst Outdated
* :doc:`discussions/index` that provide comprehensive documentation on specific topics.
* :doc:`specifications/index` for detailed information about packaging specifications.

Additionally, there is a list of :doc:`other projects <key_projects>` maintained by members of the Python Packaging Authority.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

members of the Python Packaging Authority -> the Python Packaging Authority

Well, probably? I'm not sure the distinction between members and the PyPA itself is meaningful. I assume it isn't and figure this change would be consistent with the other line about the PyPA above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important here to keep the distinction, some of these projects are rather independent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds good.

@theacodes
Copy link
Member Author

Thanks for the review, @ddbeck!

@theacodes theacodes merged commit 78c0d91 into pypa:master Jun 16, 2017
@theacodes theacodes deleted the new-landing-page branch June 16, 2017 19:09
@ncoghlan
Copy link
Member

I like the update, but it turns out that the paragraph based structure of the Get started section made the tutorial links less obvious to me than the bullet points in the Learn More section.

What do you think about laying out that section something like:

Get Started

Essential tools and concepts for working with the Python Packaging ecosystem are covered in our Tutorials section:

  • to learn how to install packages, see the tutorial on installing packages.
  • to learn how to package and distribute your projects, see the tutorial on packaging and distributing

That way, all 5 of the key links on the page (installation tutorial, publishing tutorial, guides section, discussion section, specification section), would all be highlighted as bullet points.

@ncoghlan
Copy link
Member

(PR incoming, as I originally didn't write one because I wasn't sure how I thought the section should look, but articulating the question clarified what I actually wanted)

@theacodes
Copy link
Member Author

theacodes commented Jun 17, 2017 via email

@ncoghlan
Copy link
Member

@jonparrott already reviewed it, but for future reference: #327 :)

ncoghlan pushed a commit to ncoghlan/packaging.python.org that referenced this pull request Jun 24, 2017
Use friendlier language
Be more authoritative
Briefly explain the various types of documentation here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants