Skip to content

--force-reinstall should probably work without needing to pass --upgrade #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Julian opened this issue Aug 13, 2013 · 6 comments · Fixed by #4432
Closed

--force-reinstall should probably work without needing to pass --upgrade #1139

Julian opened this issue Aug 13, 2013 · 6 comments · Fixed by #4432
Labels
auto-locked Outdated issues that have been locked by automation C: upgrade The logic of upgrading packages type: bug A confirmed bug or unintended behavior

Comments

@Julian
Copy link
Contributor

Julian commented Aug 13, 2013

It's always bugged me to need to pass -U here, and I don't see an open ticket for it.

--force-reinstall should force a reinstall I think, upgrade or not.
@pakal
Copy link

pakal commented Jun 18, 2014

I'm also quite confused with the flags force_reinstall and ignore_installed (CF pip/req.py).

Actually force_reinstall seems to do the same as ignore_installed, except that it also works in the context of an upgrade.

Why not get rid of force_reinstall, and simply advocate ignore_installed to force reinstallation in any case ? What are the use cases for this flag ?

@ulope
Copy link

ulope commented Aug 28, 2015

I've just had a co-worker get very confused by this. IMO --force-reinstall should do exactly what it says on the tin - reinstall the given package without requiring any other arguments.

@intgr
Copy link

intgr commented Oct 5, 2015

+1, I was confused by this behavior as well.

@cjerdonek cjerdonek mentioned this issue Apr 4, 2017
Closed
@cjerdonek
Copy link
Member

See more recent discussion related to this here: issue #4400.

@cjerdonek cjerdonek mentioned this issue Apr 9, 2017
Merged
@cjerdonek
Copy link
Member

I submitted a PR for this here (with tests): #4432 .

cjerdonek added a commit to cjerdonek/pip that referenced this issue Aug 3, 2017
@cjerdonek
Add failing tests for issue pypa#1139 re: --force-reinstall.
6a67f96
cjerdonek added a commit to cjerdonek/pip that referenced this issue Aug 3, 2017
@cjerdonek
Address issue pypa#1139: make --force-reinstall not require --upgrade.
c0d19e4
@cjerdonek
Copy link
Member

I rebased my PR for this issue: PR #4432. It has tests, etc.

@cjerdonek cjerdonek mentioned this issue Aug 3, 2017
Merged
dstufft pushed a commit that referenced this issue Aug 9, 2017
@cjerdonek @dstufft
Refactor in preparation for issue #1139 fix. (#4644)
d5402d3
cjerdonek added a commit to cjerdonek/pip that referenced this issue Oct 23, 2017
@cjerdonek
Add failing tests for issue pypa#1139 re: --force-reinstall.
e6a0f22
cjerdonek added a commit to cjerdonek/pip that referenced this issue Oct 23, 2017
@cjerdonek
Address issue pypa#1139: make --force-reinstall not require --upgrade.
4a93144
xavfernandez pushed a commit that referenced this issue Oct 23, 2017
@cjerdonek @xavfernandez
Address issue #1139: make --force-reinstall not require --upgrade (#4432
b112292 
)

* Add failing tests for issue #1139 re: --force-reinstall.

* Address issue #1139: make --force-reinstall not require --upgrade.

* Address review comments.

* Address @xavfernandez's review comments.

This makes the new tests not require network access.
@benoit-pierre benoit-pierre mentioned this issue Oct 27, 2017
Closed
kianasun pushed a commit to kianasun/pip that referenced this issue Mar 28, 2018
@cjerdonek @kianasun
Address issue pypa#1139: make --force-reinstall not require --upgrade (…
12ed27f 
…pypa#4432)

* Add failing tests for issue pypa#1139 re: --force-reinstall.

* Address issue pypa#1139: make --force-reinstall not require --upgrade.

* Address review comments.

* Address @xavfernandez's review comments.

This makes the new tests not require network access.
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: upgrade The logic of upgrading packages type: bug A confirmed bug or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address issue #1139: make --force-reinstall not require --upgrade cjerdonek/pip
5 participants
@ulope @intgr @Julian @pakal @cjerdonek