Improve handling of wheels with invalid versions #10945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
type: enhancement
pradyunsg
changed the title
pradyunsg
force-pushed
the
better-invalid-version
branch
from
bfab215 to
f58de94
Compare
|
I'm not too keen on adding extensive tests here, but feel free to ask for more if you'd like them! :) |
pradyunsg
force-pushed
the
better-invalid-version
branch
from
f58de94 to
49b8a2b
Compare
Instead of immediately turning the behaviour into a failure, this deprecates all the invalid wheel combinations; presenting a deprecation warning with a deadline. These conditionals can later be simplified to remove the `is_file` checks and only have the assertions/errors, dropping all the branches that call `deprecated`.
pradyunsg
force-pushed
the
better-invalid-version
branch
from
49b8a2b to
e542847
Compare
uranusjr
reviewed
Apr 9, 2022
Comment on lines
+282
to
+285
| f"Got an name mismatch in wheel ({name} != {wheel_name}) " | ||
| f"for {wheel.filename}, which is not permitted " | ||
| "as per the wheel specification." | ||
| ), |
There was a problem hiding this comment.
We should also mention which one pip is going to use.
There was a problem hiding this comment.
We have name in there, along with wheel's name.
There was a problem hiding this comment.
Yes but we don’t say which one of them we’re going to use as the package’s name in later parts of the installation.
github-actions
bot
added
the
needs rebase or merge
|
Closing this for now, we can revisit this later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9188